Replace assert with llvm_unreachable
#32707
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DougGregor
reviewed
Jul 4, 2020
| @@ -209,6 +209,7 @@ class LLVM_LIBRARY_VISIBILITY LinearLifetimeChecker::ErrorBuilder { | |||
|
|
|||
| llvm::errs() << "Found ownership error?!\n"; | |||
| assert(0 && "triggering standard assertion failure routine"); | |||
| return true; | |||
There was a problem hiding this comment.
llvm_unreachable("message") is the canonical way to write assert(0 && "message");, and should avoid this failure
There was a problem hiding this comment.
Will llvm_unreachable() avoid the PrettyStackTrace swallowing?
#32500
There was a problem hiding this comment.
Yea. It will be fine. I don't remember why I did it this way. I was pretty working quickly.
There was a problem hiding this comment.
The problem in that other one was llvm::report_fatal_error.
|
Can you change this to llvm_unreachable and then LGTM? |
texasmichelle
changed the title
assert with llvm_unreachable
gottesmm
approved these changes
Jul 6, 2020
|
@swift-ci smoke test and merge |
1 similar comment
|
@swift-ci smoke test and merge |
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an explicit return of true to ensure all paths return a value. Even though this code path is effectively unreachable, it resolves the build error: