test: make test_util more Python 3 friendly
#32710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
Build failed |
|
Build failed |
|
@swift-ci please test Windows platform |
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
|
Build failed |
|
Build failed |
This uses `io.open` to allow `test_util` to open with the encoding and newline handling across python 2 and python 3. With this change, the test suite failures are within the single digits locally.
This is required to ensure that we encode the strings correctly when redirected. This allows the printing to succeed where it would fail previously due to encoding failures.
|
@swift-ci please test |
|
Build failed |
Appease the python linter
|
@swift-ci please python lint |
|
@swift-ci please test |
|
@swift-ci please test windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses
io.opento allowtest_utilto open with the encoding andnewline handling across python 2 and python 3. With this change, the
test suite failures are within the single digits locally.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.