Skip to content

[5.3][CSBindings] Open collection binding associated with @autoclosure argument #32728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2020

Conversation

xedin
Copy link
Contributor

@xedin xedin commented Jul 6, 2020

Cherry-pick of #32724


  • Explanation:

To preserve subtype relationship between element types of a collection
passed as an argument to a parameter represented by another collection
type let's extend opening of the collection types to be done for arguments
to @autoclosure parameters as well because implicit closure is transparent
to the caller.

  • Scope: Limited to @autoclosure arguments represented by a collection type.

  • Resolves: rdar://problem/65088975

  • Risk: Very Low

  • Testing: Added regression tests

  • Reviewer: @DougGregor, @hborla

Resolves: SR-13135
Resolves: rdar://problem/65088975
(cherry picked from commit 739ba4b)

…ument

To preserve subtype relationship between element types of a collection
passed as an argument to a parameter represented by another collection
type let's extend opening of the collection types to be done for arguments
to @autoclosure parameters as well because implicit closure is transparent
to the caller.

Resolves: [SR-13135](https://bugs.swift.org/browse/SR-13135)
Resolves: rdar://problem/65088975
(cherry picked from commit 739ba4b)
@xedin xedin requested a review from a team as a code owner July 6, 2020 21:47
@xedin xedin added the r5.3 label Jul 6, 2020
@xedin
Copy link
Contributor Author

xedin commented Jul 6, 2020

@swift-ci please test

@xedin xedin merged commit c972b83 into swiftlang:release/5.3 Jul 7, 2020
@AnthonyLatsis AnthonyLatsis added swift 5.3 🍒 release cherry pick Flag: Release branch cherry picks labels Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 5.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants