docs: make Windows build instructions fully self-contained #32731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the extra repository dependency for the single cache file. Update the build examples to simplify the cmake invocation appropriately.
|
@swift-ci please smoke test |
gribozavr
reviewed
Jul 7, 2020
| ``` | ||
|
|
||
| Extract the zip files, ignoring the top level directory, into `S:/Library`. The directory structure should resemble: | ||
| The instructions assume that the dependencies are in `S:/Library`. The directory |
There was a problem hiding this comment.
The instructions now don't say how to get the dependencies; why not?
There was a problem hiding this comment.
Simply to close make the repository self-contained. The intent was to remove the references to my repository and the Azure setup. The ICU dependency is external. If you have a good way to handle this, Im happy to adjust the instructions accordingly.
shahmishal
approved these changes
Jul 7, 2020
|
⛵ |
|
Looks like we still needed to answer @gribozavr question. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the extra repository dependency for the single cache file.
Update the build examples to simplify the cmake invocation
appropriately.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.