[Explicit Module Builds] Add canImport functionality to the ExplicitSwiftModuleLoader #32754
Conversation
|
@swift-ci please test |
|
@swift-ci Please test Windows platform |
…wiftModuleLoader It needs to check against the provided ExplicitModuleMap instead of looking into search paths.
artemcm
force-pushed
the
CanImportExplicitly
branch
from
b6aab2c to
f361b25
Compare
|
@swift-ci please test |
|
Build failed |
|
Build failed |
| bool ExplicitSwiftModuleLoader::canImportModule( | ||
| Located<Identifier> mID) { | ||
| StringRef moduleName = mID.Item.str(); | ||
| auto it = Impl.ExplicitModuleMap.find(moduleName); |
There was a problem hiding this comment.
This is not something you would change in this PR, but…why is ExplicitModuleMap keyed by StringRefs? I would expect Identifier keys to be faster, since Identifiers are interned and can be compared more efficiently.
There was a problem hiding this comment.
I suspect this is to do with the fact that ExplicitModuleMap is built by parsing out a JSON file (generated in the swift-driver), and at the point it is created perhaps Identifier keys are not available. @nkcsgexi can confirm.
There was a problem hiding this comment.
This is because we initially used StringRef to the underlying JSON buffer as the key, but we could potentially change it to ASTContext-owned identifiers now.
|
Independent of this change, we should also teach scan-dependencies action to eliminate all non-importable modules from the reported dependencies. |
It needs to check against the provided ExplicitModuleMap instead of looking into search paths.