[Test] Specialize Prototypes/BigInt.swift for Windows. #32773
Conversation
|
@swift-ci please test |
|
This test will fail on all builders, not just MacOS, when asserts are on. I originally added an 'XFAIL: asserts', but then @compnerd changed it further in this commit: @compnerd Can you investigate why the XFAIL: asserts was not enough on Windows? |
|
I think we need to revert e02438c and fix the Windows build separately. This PR will also not work, because "not --crash" is not the right expectation on a no-asserts build. The test passes on a no-asserts build. |
|
@slavapestov the reason that |
nate-chandler
force-pushed
the
rdar65251059
branch
2 times, most recently
from
41d9053 to
cb998d3
Compare
nate-chandler
changed the title
|
@swift-ci please test and merge |
1 similar comment
|
@swift-ci please test and merge |
nate-chandler
force-pushed
the
rdar65251059
branch
from
cb998d3 to
6b1776b
Compare
Building the file with asserts crashes the compiler. Building the file with no_asserts does *not* crash the compiler. For non-Windows platforms, it is sufficient to `XFAIL: asserts`. That does not work on Windows thanks to Python < 3: the crash is not handled by lit's `not` there as it is on other platforms. To handle the expected crash on Windows when building with asserts, not --crash is required. However on other platforms, not --crash breaks the test in no_asserts builds. Here, a version of the test's run script specialized for Windows is broken out into a separate BigInt-windows.swift file. rdar://problem/65251059
nate-chandler
force-pushed
the
rdar65251059
branch
from
6b1776b to
bdbcec6
Compare
|
@swift-ci please test |
|
@swift-ci please test windows |
|
Build failed |
nate-chandler
changed the title
|
@swift-ci please test windows |
|
Build failed |
|
@swift-ci please clean test |
Building the file with asserts crashes the compiler. Building the file with no_asserts does not crash the compiler.
For non-Windows platforms, it is sufficient to
XFAIL: asserts.That does not work on Windows thanks to Python < 3: the crash is not handled by lit's
notthere as it is on other platforms. To handle the expected crash on Windows when building with asserts, not --crash is required. However on other platforms, not --crash breaks the test in no_asserts builds.Here, a version of the test's run script specialized for Windows is broken out into a separate BigInt-windows.swift file.
rdar://problem/65251059