Skip to content

Remove -sil-merge-partial-modules #32777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2020

Conversation

hamishknight
Copy link
Contributor

Since #32461, this is now the default behaviour for -merge-modules.

@slavapestov
Copy link
Contributor

How about removing the flag altogether from FrontendOptions.td?

@hamishknight
Copy link
Contributor Author

hamishknight commented Jul 9, 2020

@slavapestov I wasn't sure if we had any other clients relying on it – that being said I don't think we promise a stable interface for the frontend (is that right? edit: yup, just checked in the docs), so yeah let's just remove it.

This is now the default behaviour for -merge-modules. Stop
passing it in the driver and remove it from FrontendOptions.td.
@hamishknight hamishknight changed the title [Driver] Stop passing -sil-merge-partial-modules Remove -sil-merge-partial-modules Jul 9, 2020
@hamishknight
Copy link
Contributor Author

swiftlang/llvm-project#1434

@swift-ci please smoke test

@hamishknight hamishknight merged commit f8ee94d into swiftlang:master Jul 9, 2020
@hamishknight hamishknight deleted the out-of-the-link branch July 9, 2020 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants