Skip to content

Teach EscapeAnalysis to ignore end_access markers. #32836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2020

Conversation

atrick
Copy link
Contributor

@atrick atrick commented Jul 11, 2020

The presence of end_access markers was causing object properties to
appear to escape globally. That's too conservative.

The presence of end_access markers was causing object properties to
appear to escape globally. That's too conservative.
@atrick atrick requested a review from meg-gupta July 11, 2020 08:27
@atrick
Copy link
Contributor Author

atrick commented Jul 11, 2020

@swift-ci test

@atrick
Copy link
Contributor Author

atrick commented Jul 11, 2020

@swift-ci benchmark

@atrick
Copy link
Contributor Author

atrick commented Jul 11, 2020

@swift-ci test source compatibility

@swift-ci
Copy link
Contributor

Performance: -O

Code size: -O

Performance: -Osize

Improvement OLD NEW DELTA RATIO
FlattenListFlatMap 3848 3507 -8.9% 1.10x (?)

Code size: -Osize

Performance: -Onone

Regression OLD NEW DELTA RATIO
DataAppendDataSmallToSmall 2780 3120 +12.2% 0.89x (?)
 
Improvement OLD NEW DELTA RATIO
ObjectiveCBridgeStubToNSDateRef 2720 2540 -6.6% 1.07x (?)
WordCountHistogramASCII 94100 87900 -6.6% 1.07x (?)

Code size: -swiftlibs

How to read the data The tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.

If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.

Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview
  Model Name: Mac mini
  Model Identifier: Macmini8,1
  Processor Name: 6-Core Intel Core i7
  Processor Speed: 3.2 GHz
  Number of Processors: 1
  Total Number of Cores: 6
  L2 Cache (per Core): 256 KB
  L3 Cache: 12 MB
  Memory: 64 GB

Copy link
Contributor

@meg-gupta meg-gupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@atrick atrick merged commit 856afbb into swiftlang:master Jul 11, 2020
@atrick atrick deleted the opt-escape-endaccess branch July 13, 2020 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants