Skip to content

validation: make UnsafeBufferPointer Python3 friendly #32849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2020

Conversation

compnerd
Copy link
Member

The <> operator does not work in Python 3. Switch it out for !=.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

The `<>` operator does not work in Python 3.  Switch it out for `!=`.
@compnerd
Copy link
Member Author

CC: @tachoknight @drexin @tbkka @lorentey

Copy link
Contributor

@tbkka tbkka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should work equally in Python 2 and 3.

@CodaFi
Copy link
Contributor

CodaFi commented Jul 13, 2020

@swift-ci test

1 similar comment
@CodaFi
Copy link
Contributor

CodaFi commented Jul 14, 2020

@swift-ci test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 4cd8121

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 4cd8121

@compnerd
Copy link
Member Author

@swift-ci please test

@CodaFi
Copy link
Contributor

CodaFi commented Jul 14, 2020

@CodaFi CodaFi merged commit b00753a into swiftlang:master Jul 14, 2020
@compnerd compnerd deleted the spaceships branch July 14, 2020 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants