Skip to content

Avoid creating a ConcurrentMap for nongeneric instantiated witness tables #32894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 17, 2020
Merged

Avoid creating a ConcurrentMap for nongeneric instantiated witness tables #32894

merged 1 commit into from
Jul 17, 2020

Conversation

jckarter
Copy link
Contributor

No description provided.

@jckarter jckarter requested review from slavapestov and mikeash July 15, 2020 01:32
@jckarter jckarter force-pushed the singleton-witness-table-instantiation branch from fca66ef to 262b713 Compare July 15, 2020 19:12
slavapestov
slavapestov reviewed Jul 15, 2020
View reviewed changes
@jckarter jckarter force-pushed the singleton-witness-table-instantiation branch from 262b713 to fb647eb Compare July 15, 2020 21:44
@jckarter
Copy link
Contributor Author

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - fb647eb5686f5c61419d665c6bc2da6e2d668acb

@jckarter jckarter force-pushed the singleton-witness-table-instantiation branch from fb647eb to 7898875 Compare July 15, 2020 23:15
@jckarter
Copy link
Contributor Author

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - fb647eb5686f5c61419d665c6bc2da6e2d668acb

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - fb647eb5686f5c61419d665c6bc2da6e2d668acb

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - fb647eb5686f5c61419d665c6bc2da6e2d668acb

@jckarter jckarter force-pushed the singleton-witness-table-instantiation branch from 7898875 to 839c093 Compare July 16, 2020 18:46
@jckarter jckarter force-pushed the singleton-witness-table-instantiation branch from 839c093 to 88d9641 Compare July 16, 2020 19:00
@jckarter
Copy link
Contributor Author

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 7898875a4aca8d3abae50fd01aa0569b693145d8

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 7898875a4aca8d3abae50fd01aa0569b693145d8

@jckarter jckarter marked this pull request as ready for review July 16, 2020 21:43
@airspeedswift
Copy link
Member

@swift-ci please test macOS

@jckarter jckarter mentioned this pull request Jul 17, 2020
Merged
@jckarter jckarter merged commit bac92e9 into swiftlang:master Jul 17, 2020
@jckarter jckarter changed the title [WIP] Avoid creating a ConcurrentMap for nongeneric instantiated witness tables Avoid creating a ConcurrentMap for nongeneric instantiated witness tables Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slavapestov slavapestov slavapestov left review comments

@mikeash mikeash Awaiting requested review from mikeash

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jckarter @swift-ci @airspeedswift @slavapestov