[AutoDiff] remove all-concrete gen sig from more places #32916
Conversation
|
@swift-ci please test and merge |
|
@swift-ci please test and merge |
|
@swift-ci Please test Linux |
| @@ -530,8 +530,10 @@ void TBDGenVisitor::addAutoDiffLinearMapFunction(AbstractFunctionDecl *original, | |||
| config.parameterIndices, | |||
| original->getInterfaceType()->castTo<AnyFunctionType>()); | |||
| Mangle::ASTMangler mangler; | |||
| AutoDiffConfig silConfig{loweredParamIndices, config.resultIndices, | |||
| config.derivativeGenericSignature}; | |||
| AutoDiffConfig silConfig{ | |||
There was a problem hiding this comment.
Can you create a new SILDeclRef-like abstraction that can allow this logic to be shared between TBDGen and SIL?
There was a problem hiding this comment.
SILDeclRef already stores an (optional) AutoDiffDerivativeFunctionIdentifier, which has almost the same contents as AutoDiffConfig.
We could look into using that with TBDGenVisitor::addSymbol(SILDeclRef) instead of calling TBDGenVisitor::addSymbol(StringRef name) here with manually mangled names.
There was a problem hiding this comment.
Yeah, that's what I meant. TBDGen should not duplicate any logic from SILGen/IRGen, except for the top-level visiting of decls. Mangling and visibility should be computed by shared code, or else you'll hit frequent issues where the two are out of sync.
There was a problem hiding this comment.
Got it, thanks! I filed SR-13269 to track this issue so we can look into it later, if that's okay.
#32803 removed all-concrete derivative generic signatures from some places. There were a few remaining places where it wasn't removed, causing problems:
diagnoseUnsatisfiedRequirementsto think that a requirement is unsatisfied when the requirement actually doesn't exist. The included test causesa.sum()to have an incorrect diagnostic "unsatisfied requirement Element == S".This PR fixes both places.
(Discovered while testing the recent merge into tensorflow.)