Skip to content

Fix a couple of memory bugs #32955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 17, 2020
Merged

Conversation

hamishknight
Copy link
Contributor

Fix a stack-use-after-scope and uninitialized variable read.

rdar://65724385
rdar://65712583
rdar://65673653

The PSPs need to live long enough for the call
to OptimizedIRRequest.

rdar://65724385, rdar://65712583
Otherwise LLDB may leave them uninitialized.

rdar://65673653
@hamishknight
Copy link
Contributor Author

@swift-ci please smoke test

Copy link
Contributor

@CodaFi CodaFi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tanquam ex ungue leonem

@shahmishal
Copy link
Member

@swift-ci please smoke test windows

@hamishknight hamishknight merged commit 5e9934c into swiftlang:master Jul 17, 2020
@hamishknight hamishknight deleted the thanks-asan branch July 17, 2020 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants