Verify OSSA address phis. #32992
Verify OSSA address phis. #32992
Conversation
Verify that address phis are prohibited in all OSSA passes. Eventually they should be prohibited in all passes. This at least allows preserving access markers in OSSA passes.
|
@swift-ci test |
|
@swift-ci test source compatibility |
|
Build failed |
|
Test failure: emit-forward-modules.swift swiftmodule '/Volumes/swift-ci/jenkins/workspace/swift-PR-osx/branch-master/buildbot_incremental/swift-macosx-x86_64/test-iphonesimulator-i386/ModuleInterface/Output/emit-forward-modules.swift.tmp/Foo.swiftmodule/i386-apple-ios-simulator.swiftmodule' is not a forwarding module! |
|
@swift-ci smoke test macOS |
|
@gottesmm @meg-gupta OSSA passes should be able to rely on the presence of begin/end_access markers. I believe SemanticARCOpts already does. We should make sure AccessMarkerElimination always runs after OwnershipElimination. As part of migrating tests to OSSA, we should also add the access markers. Eventually, AccessMarkerElimination can go away entirely. When access markers present it's easier to analyze memory access, and also allows fixing some of the pass ordering problems today where access enforcement selection can only be done very early. |
|
LGTM. Thanks! |
Verify that address phis are prohibited in all OSSA passes.
Eventually they should be prohibited in all passes. This at least
allows preserving access markers in OSSA passes.