Add a switch to not include git commit hash in the built artifacts #32998
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
Build failed |
|
Build failed |
gribozavr
approved these changes
Jul 20, 2020
compnerd
reviewed
Jul 20, 2020
|
@swift-ci please test |
|
Build failed |
|
Build failed |
compnerd
approved these changes
Jul 22, 2020
|
@swift-ci please test |
|
Build failed |
|
Build failed |
|
@swift-ci please test |
|
Build failed |
|
Build failed |
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
SWIFT_APPEND_VC_REVCmake option (in symmetry with LLVM'sLLVM_APPEND_VC_REV).When enabled,
lib/Basic/SwiftRevision.incheader contains git commit hash and repository information, e.g.This is useful for keeping track of the VCS state that produced a binary. But for local development builds, this information is often ignored and since this file is invalidated by every
git commitorgit checkoutcommand and it leads to long rebuilds, it's useful to have a switch to disable this behavior. WhenSWIFT_APPEND_VC_REVis disabled,lib/Basic/SwiftRevision.inccontains: