[CS] Connect arg-to-param constraint to function builder #33005
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Factor out the callee locator computation and function builder opening logic.
We used to apply builder transforms to regular functions without using a constraint system, which is what the assertion is primarily geared towards. However we now use a constraint system for such cases, with the lack of a constraint system only being used to check if we can even apply the transform in the first place.
Previously we could inadvertently split the constraint system without realizing that a function builder with a generic argument may allow the closure body to reference a type variable that connects it to the enclosing expression. Fix this issue by checking for an unresolved closure argument and forming an unresolved argument conversion constraint that includes any type variables from the function builder type. Resolves SR-13183 Resolves rdar://problem/65695054
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we could inadvertently split the constraint system without realizing that a function builder with a generic argument may allow the closure body to reference a type variable that connects it to the enclosing expression.
Fix this issue by checking for an unresolved closure argument and forming an unresolved argument conversion constraint that includes any type variables from the function builder type.
Resolves SR-13183
Resolves rdar://problem/65695054