[opt-remark] If we have a SIL remark streamer, always emit remarks. #33018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(that is, we want to emit everything when we are streaming and let any reader of the data filter as they choose). |
|
@swift-ci smoke test and merge |
CodaFi
reviewed
Jul 20, 2020
| @@ -101,8 +101,11 @@ class OptRemarkGenerator : public SILFunctionTransform { | |||
| bool isOptRemarksEnabled() { | |||
| // TODO: Put this on LangOpts as a helper. | |||
| auto &langOpts = getFunction()->getASTContext().LangOpts; | |||
|
|
|||
| // If we have a remark streamer, emit everything. | |||
| return bool(langOpts.OptimizationRemarkMissedPattern) || | |||
There was a problem hiding this comment.
@francisvm This whole predicate seems a little odd. Seems like we can clean up a bunch of checks in the emitter itself if it had a direct reference to the module's remark streamer instead of the module itself.
There was a problem hiding this comment.
The only issue I see is that the remark streamer is only used to serialize remarks, while the emitter is used to emit both diagnostics and serialize remarks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I spoke with Francis and this is the expected behavior.