[5.3] [CS] Emit syntactic diagnostics for for loop where clauses #33041
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a function that deals with invoking syntactic diagnostics for all the expressions involved in a SolutionApplicationTarget. Resolves SR-13260 Resolves rdar://65903005
|
@swift-ci please test |
DougGregor
approved these changes
Jul 22, 2020
AnthonyLatsis
added
swift 5.3
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
5.3 cherry-pick of #33037, minus the last commit which is just a refactor.
Explanation: Fixes a 5.3 regression where we would fail to emit a group of diagnostics for the
whereclause of a for loop.Scope: Fixes a 5.3 regression that could allow us to accept invalid code.
Radar: rdar://65903005
Risk: Low, this re-enables diagnostic logic that was previously enabled in 5.2.
Testing: Added unit test.
Reviewer: @xedin.