[Function builder availability] Address review comments. #33046
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test and merge |
theblixguy
reviewed
Jul 22, 2020
| // Note that this is for staging in support for buildLimitedAvailability(); | ||
| // the diagnostic is currently a warning, so that existing code that | ||
| // compiles today will continue to compile. Once function builder types | ||
| // have had the change to adopt buildLimitedAvailability(), we'll upgrade |
There was a problem hiding this comment.
Did you mean "chance" instead of "change"? :-)
Suggested change
| // have had the change to adopt buildLimitedAvailability(), we'll upgrade | |
| // have had the chance to adopt buildLimitedAvailability(), we'll upgrade |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.