Skip to content

[AutoDiff] Start linear_function canonicalization skeleton #33057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 23, 2020

Conversation

efremale
Copy link
Contributor

Start linear_function canonicalization skeleton copying from differentiable_function canonicalization. For now, transpose function operands are filled in with undef.

dan-zheng and others added 2 commits July 21, 2020 13:24
Remaining work in "TODO" comments.
Start `linear_function` canonicalization skeleton copying from `differentiable_function`
canonicalization. For now, transpose function operands are filled in with `undef`.
@efremale
Copy link
Contributor Author

cc @dan-zheng

@dan-zheng dan-zheng requested review from dan-zheng and rxwei July 22, 2020 20:31
Copy link
Contributor

@dan-zheng dan-zheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@dan-zheng
Copy link
Contributor

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 48980e2

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 48980e2

Linear map transposition will be enabled only if the flag is enabled.
@dan-zheng
Copy link
Contributor

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 48980e2

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 48980e2

Copy link
Contributor

@dan-zheng dan-zheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I missed a few minor details. Could you please address?

@dan-zheng
Copy link
Contributor

@swift-ci Please smoke test

@dan-zheng dan-zheng merged commit 1a81573 into swiftlang:master Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants