[sourcekitd] Fix range shifting vs semantic update timing issues #33063
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…date The goal of the test is to test the behaviour when the edit is range-shifted, but in the (rare) case where the document update happens before the edit finishes, we need the ranges to be the same. In particular, using separate statements ensures that the tokens not touched by the edit are not affected by the edit. Re-enable the test disabled on ASan, since this seems to be the underlying issue. rdar://65934938
If a semantic update finishes fast enough, the token snapshot may be identical to the edit snapshot, but because of getBufferForSnapshot consolidating edits into a new buffer, we were not detecting that case properly, and it could cause an assertion failure (or potentially incorrect range shifting in a release build). This would have reproduced very rarely in practice, but I can reproduce it by putting `sleep(2)` calls right before we read the semantic info in open and edit requests. Incidentally, fix sourcekit-test and unit tests for the (rare) case where an open or edit already has updated semantic info.
|
@swift-ci please asan test |
|
@swift-ci please test |
akyrtzi
approved these changes
Jul 23, 2020
|
Windows failure is unrelated, and seems to have been fixed already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sleep(2)calls right before we read the semantic info in open and edit requests.