[CodeCompletion] Use TypeContextInfo to get expected return types #33080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
benlangmuir
reviewed
Jul 23, 2020
lib/IDE/ExprContextAnalysis.cpp
Outdated
| // nothing. | ||
| if (candidates.empty() && ACE->getType() && !ACE->getType()->hasError()) { | ||
| candidates.push_back(ACE->getResultType()); | ||
| return; |
There was a problem hiding this comment.
Unnecessasry return. Alternatively, maybe we should early-return everywhere above that adds candidates? It's not obvious that all the above cases are mutually exclusive.
If the type check return type from the context has unresolved types, it can't be used for checking convertibility. Fallback to get 'TypeContextInfo' of the closure position. rdar://problem/66002497
rintaro
force-pushed
the
ide-completion-rdar66002497
branch
from
17e15d9 to
dab216d
Compare
|
@swift-ci Please smoke test |
benlangmuir
approved these changes
Jul 23, 2020
|
@swift-ci Please smoke test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the type checked return type from the context has unresolved types, it can't be used for checking convertibility. Fallback to get
TypeContextInfoof the closure position.https://bugs.swift.org/browse/SR-13271 / rdar://problem/66002497