Skip to content

Pass architecture into Benchmark_Driver to fix build-script -B #33100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 25, 2020

Conversation

tbkka
Copy link
Contributor

@tbkka tbkka commented Jul 24, 2020

Recent changes to integrate Apple Silicon support modified how Benchmark drivers are invoked. Specifically, the generated benchmarking program now includes the target architecture as part of the executable name.

This PR passes the target architecture information into Benchmark_Driver so that build-script -B will work again.

Related to: #32923

@tbkka
Copy link
Contributor Author

tbkka commented Jul 24, 2020

@swift-ci Please benchmark

@tbkka
Copy link
Contributor Author

tbkka commented Jul 24, 2020

@swift-ci Please smoke test

@tbkka
Copy link
Contributor Author

tbkka commented Jul 24, 2020

@swift-ci Please benchmark

1 similar comment
@tbkka
Copy link
Contributor Author

tbkka commented Jul 25, 2020

@swift-ci Please benchmark

@swift-ci
Copy link
Contributor

Performance: -O

Code size: -O

Performance: -Osize

Regression OLD NEW DELTA RATIO
ObjectiveCBridgeStubToNSDate2 550 620 +12.7% 0.89x (?)

Code size: -Osize

Performance: -Onone

Code size: -swiftlibs

How to read the data The tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.

If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.

Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview
  Model Name: Mac Pro
  Model Identifier: MacPro6,1
  Processor Name: 12-Core Intel Xeon E5
  Processor Speed: 2.7 GHz
  Number of Processors: 1
  Total Number of Cores: 12
  L2 Cache (per Core): 256 KB
  L3 Cache: 30 MB
  Memory: 64 GB

@tbkka tbkka merged commit ab861d5 into swiftlang:master Jul 25, 2020
@tbkka tbkka deleted the tbkka/Benchmark-fixes branch October 16, 2020 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants