Skip to content

[CMake] BUILD_SHARED_LIBS fixes #33129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 27, 2020
Merged

[CMake] BUILD_SHARED_LIBS fixes #33129

merged 1 commit into from
Jul 27, 2020

Conversation

davezarzycki
Copy link
Contributor

No description provided.

@davezarzycki
Copy link
Contributor Author

@swift-ci please smoke test

compnerd
compnerd approved these changes Jul 27, 2020
View reviewed changes
Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really wish that we used the llvm tooling to build so we could get the dependencies handled correctly.

Thanks for fixing this.

@davezarzycki
Copy link
Contributor Author

I also wish that Swift leveraged BUILD_SHARED_LIBS rather than just supporting LLVM using that build setup.

There is a lot of layering inversions in the compiler that would get exposed and fixed that way.

@davezarzycki davezarzycki merged commit 8a45c9c into swiftlang:master Jul 27, 2020
@davezarzycki davezarzycki deleted the pr33129 branch July 27, 2020 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compnerd compnerd compnerd approved these changes

@akyrtzi akyrtzi Awaiting requested review from akyrtzi

@gottesmm gottesmm Awaiting requested review from gottesmm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davezarzycki @compnerd