Skip to content

[build-script] copy over the simulator libclang_rt.*.a libraries to a… #33133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 28, 2020
Merged

[build-script] copy over the simulator libclang_rt.*.a libraries to a… #33133

merged 1 commit into from
Jul 28, 2020

Conversation

hyp
Copy link
Contributor

@hyp hyp commented Jul 27, 2020

…llow clang to link with them

Clang's driver started linking with libclang_rt.sim.a when building for simulator.

Swift's build need to adapt to this clang change, by ensuring that the libclang_rt.sim.a libraries are created during the build

@hyp hyp requested a review from shahmishal July 27, 2020 17:32
@hyp
Copy link
Contributor Author

hyp commented Jul 27, 2020

@swift-ci please test

@hyp
Copy link
Contributor Author

hyp commented Jul 27, 2020

@swift-ci please build toolchain

@swift-ci
Copy link
Contributor

Linux Toolchain (Ubuntu 16.04)
Download Toolchain
Git Sha - ab31e19c035d424c7e41188a5c05af4f02209768

Install command
tar zxf swift-PR-33133-406-ubuntu16.04.tar.gz
More info

@swift-ci
Copy link
Contributor

macOS Toolchain
Download Toolchain
Git Sha - ab31e19c035d424c7e41188a5c05af4f02209768

Install command
tar -zxf swift-PR-33133-581-osx.tar.gz --directory ~/

@hyp
[build-script] copy over the simulator libclang_rt.*.a libraries to a…
3320d23 
…llow clang to link with them

Clang's driver started linking with libclang_rt.<os>sim.a when building for simulator.

Swift's build need to adapt to this clang change, by ensuring that the libclang_rt.<os>sim.a libraries are created during the build
@hyp hyp force-pushed the compiler-rt-sim-libs branch from ab31e19 to 3320d23 Compare July 27, 2020 20:07
@hyp
Copy link
Contributor Author

hyp commented Jul 27, 2020

@swift-ci please build toolchain

@hyp
Copy link
Contributor Author

hyp commented Jul 27, 2020

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - ab31e19c035d424c7e41188a5c05af4f02209768

@swift-ci
Copy link
Contributor

Linux Toolchain (Ubuntu 16.04)
Download Toolchain
Git Sha - 3320d23

Install command
tar zxf swift-PR-33133-407-ubuntu16.04.tar.gz
More info

@shahmishal
Copy link
Member

@swift-ci please build toolchain macOS

@swift-ci
Copy link
Contributor

macOS Toolchain
Download Toolchain
Git Sha - 3320d23

Install command
tar -zxf swift-PR-33133-583-osx.tar.gz --directory ~/

@fredriss fredriss merged commit a1ae109 into swiftlang:master Jul 28, 2020
@edymtt edymtt mentioned this pull request Oct 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahmishal shahmishal shahmishal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hyp @swift-ci @shahmishal @fredriss