[sil] Add an implicit operator bool conversion to SILDebugLocation. #33161
Conversation
The reason to do this is that one can now do:
```
if (auto debugLoc = i.getDebugLocation()) {
// do something with debug loc.
}
```
I also cleaned up the style a little bit by renaming the internal ivars to be
camelCase.
|
@swift-ci smoke test |
| @@ -755,17 +755,18 @@ class SILDebugScope; | |||
|
|
|||
| /// A SILLocation paired with a SILDebugScope. | |||
| class SILDebugLocation { | |||
| const SILDebugScope *Scope = nullptr; | |||
| SILLocation Location; | |||
| const SILDebugScope *debugScope; | |||
There was a problem hiding this comment.
The original code used the LLVM naming convention. Do we now have a Swift naming convention that's different from the LLVM one?
There was a problem hiding this comment.
Yes. Swift does camelCase for variables. We are slowly changing over time.
There was a problem hiding this comment.
And LLVM is changing more to that style as well
| : Scope(DS), Location(Loc) {} | ||
| SILLocation getLocation() const { return Location; } | ||
| const SILDebugScope *getScope() const { return Scope; } | ||
| : debugScope(nullptr), |
There was a problem hiding this comment.
I prefer the = nullptr spelling, since it makes it harder to forget to initialize the member when adding a new constructor.
There was a problem hiding this comment.
Ok. To me it just looked redundant. I am fine fixing it in a follow on commit.
| : debugScope(debugScope), location(location) {} | ||
| SILLocation getLocation() const { return location; } | ||
| const SILDebugScope *getScope() const { return debugScope; } | ||
| operator bool() const { return bool(location) && debugScope; } |
Are there any legitimate cases where we would have an invalid location on an instruction when we're not inside of SILGen or SILParser? |
|
@adrian-prantl It can happen at any time and code (like what I am writing now) should be able to be conservative, unless there is a verification check that I can depend on this always being there. |
The reason to do this is that one can now do:
I also cleaned up the style a little bit by renaming the internal ivars to be
camelCase.