[5.3][AST] Mark repr invalid only if @autoclosure parameter doesn't poin…
#33162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t to function type Instead on depending on repr to be a function, let's only check whether type resolved for `@autoclosure` points to a function type because it's allowed for `@autoclosure` parameters to be to wrapped into parens or be represented by a typealias. Resolves: rdar://problem/65704049 (cherry picked from commit f2c2aa5)
|
@swift-ci please test |
devincoughlin
approved these changes
Jul 29, 2020
AnthonyLatsis
added
swift 5.3
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…t to function type
Cherry-pick of #33145
Instead on depending on repr to be a function, let's only check
whether type resolved for
@autoclosurepoints to a function typebecause it's allowed for
@autoclosureparameters to be towrapped into parens or be represented by a typealias.
Scope: Limited to declarations which use
@autoclosurewith parens or typealias.Resolves: rdar://problem/65704049
Risk: Very Low
Testing: Added regression tests
Reviewer: @rintaro
Resolves: rdar://problem/65704049
(cherry picked from commit f2c2aa5)