[CSBindings] Refactor getPotentialBindings into inferBindingsFor + infer
#33164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…+ `infer` Split `getPotentialBindings` in two: - `inferBindingsFor` should take responsibility for binding constraints to be evaluated as potential binding sources; - `PotentialBindings::infer` would process constraints provided by `inferBindingsFor` and "extract" bindings from them. This is done to separate "sourcing" logic from "inference" and make the former pluggable, so bindings could be computed based on changes in constraint graph in the future.
|
@swift-ci please test source compatibility |
|
@swift-ci please test source compatibility release |
|
@swift-ci please test |
|
@swift-ci please test source compatibility release |
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split
getPotentialBindingsin two:inferBindingsForshould take responsibility for finding constraintsto be evaluated as potential binding sources;
PotentialBindings::inferwould process constraints provided byinferBindingsForand "extract" bindings from them.This is done to separate "sourcing" logic from "inference" and
make the former pluggable, so bindings could be computed based
on changes in constraint graph in the future.