[silgen] Mark a bunch of functions that SILGen open-codeds as "auto-generated" and thus not user generated code. #33166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
@swift-ci test source compatibility |
|
Doing a bigger test to make sure nothing changes (in a paranoid sort of way) |
jckarter
reviewed
Jul 28, 2020
| @@ -1284,22 +1302,22 @@ void SILGenModule::emitDestructor(ClassDecl *cd, DestructorDecl *dd) { | |||
| if (dd->hasBody()) { | |||
| SILDeclRef destroyer(dd, SILDeclRef::Kind::Destroyer); | |||
| SILFunction *f = getFunction(destroyer, ForDefinition); | |||
| preEmitFunction(destroyer, dd, f, dd); | |||
| RegularLocation loc(dd); | |||
There was a problem hiding this comment.
This change seems like NFC here (which would be correct). Just making sure, is that intentional?
There was a problem hiding this comment.
I did it to match the code all around to it.
jckarter
reviewed
Jul 28, 2020
gottesmm
force-pushed
the
pr-824f03205dd43d5614f7605c3f3ae53ac78be8cb
branch
from
32532c7 to
f3476ba
Compare
…enerated" and thus not user generated code. This ensures that we do not emit diagnostics onto these functions. I noticed we were doing this with my work on opt-remarks when I was hitting diagnostics in these functions in a set of subsequent commits. The way that I found these is that I went through this file and looked for any cases where we were never calling emitStmt on a user provided function body. I also eliminated two places where we were setting a new DebugScope even though preEmitFunction already does that for us.
gottesmm
force-pushed
the
pr-824f03205dd43d5614f7605c3f3ae53ac78be8cb
branch
from
f3476ba to
e3fa137
Compare
|
@swift-ci test |
|
@swift-ci test source compatibility |
|
Build failed |
|
@swift-ci test windows platform |
|
Release did not fail b/c of this commit. Build error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that we do not emit diagnostics onto these functions. I noticed we
were doing this with my work on opt-remarks when I was hitting diagnostics in
these functions in a set of subsequent commits.
The way that I found these is that I went through this file and looked for any
cases where we were never calling emitStmt on a user provided function body.
I also eliminated two places where we were setting a new DebugScope even though
preEmitFunction already does that for us.