Skip to content

Change ExplicitModuleInfo to have string members instead of StringRef #33170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 29, 2020
Merged

Change ExplicitModuleInfo to have string members instead of StringRef #33170

merged 1 commit into from
Jul 29, 2020

Conversation

artemcm
Copy link
Contributor

@artemcm artemcm commented Jul 28, 2020

Working around a failure caused by inability to covert StringRef to std::string& downstream.

@artemcm artemcm requested a review from nkcsgexi July 28, 2020 23:02
@artemcm
Copy link
Contributor Author

artemcm commented Jul 28, 2020

@swift-ci please test

@artemcm artemcm merged commit 256ec45 into swiftlang:master Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkcsgexi nkcsgexi nkcsgexi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@artemcm @nkcsgexi