Skip to content

Instead of random file name, use a hash as a deterministic name for Swift source file list in _compile_swift_files #33190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 3, 2020
Merged

Instead of random file name, use a hash as a deterministic name for Swift source file list in _compile_swift_files #33190

merged 1 commit into from
Aug 3, 2020

Conversation

kubamracek
Copy link
Contributor

This fixes an unnecessary rebuild of the standard library every time you trigger a CMake configure step, which was caused by using a random file name in the command line that builds stdlib. Let's use a hash of the content to get a deterministic file name.

@kubamracek
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 068f1415d417ad0bf5e25ca75f1f048512f2ffa2

@compnerd
Copy link
Member

@swift-ci please test macOS platform

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 068f1415d417ad0bf5e25ca75f1f048512f2ffa2

@kubamracek
Copy link
Contributor Author

@swift-ci please test macOS platform

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 068f1415d417ad0bf5e25ca75f1f048512f2ffa2

@kubamracek
Copy link
Contributor Author

@swift-ci please test macOS platform

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 068f1415d417ad0bf5e25ca75f1f048512f2ffa2

@kubamracek
Instead of random file name, use a hash as a deterministic name for S…
bab94db 
…wift source file list in _compile_swift_files
@kubamracek kubamracek force-pushed the source-list-file-name-as-hash branch from 83a8333 to bab94db Compare July 31, 2020 23:02
@kubamracek
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 068f1415d417ad0bf5e25ca75f1f048512f2ffa2

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 068f1415d417ad0bf5e25ca75f1f048512f2ffa2

@kubamracek
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented Aug 1, 2020

Build failed
Swift Test Linux Platform
Git Sha - bab94db

@kubamracek
Copy link
Contributor Author

@swift-ci please test linux platform

@kubamracek kubamracek merged commit c6ea30c into swiftlang:master Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compnerd compnerd compnerd approved these changes

@gottesmm gottesmm Awaiting requested review from gottesmm

@devincoughlin devincoughlin Awaiting requested review from devincoughlin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kubamracek @swift-ci @compnerd