Skip to content

[CSDiagnostics] Offer '@escaping' fix-it when type has '@autoclosure' during non-escaping function type error #33191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2020
Merged

Conversation

theblixguy
Copy link
Collaborator

If a function type was annotated with @autoclosure, we didn't use to offer the "insert @escaping" fix-it. This is now fixed.

@theblixguy theblixguy requested review from xedin and hborla July 29, 2020 21:11
@theblixguy theblixguy changed the title [CSDiagnostic] Insert '@escaping' fix-it when type has '@autoclosure' during non-escaping function type diagnostic [CSDiagnostics] Insert '@escaping' fix-it when type has '@autoclosure' during non-escaping function type diagnostic Jul 29, 2020
… during non-escaping function type diagnostic
@theblixguy theblixguy changed the title [CSDiagnostics] Insert '@escaping' fix-it when type has '@autoclosure' during non-escaping function type diagnostic [CSDiagnostics] Offer '@escaping' fix-it when type has '@autoclosure' during non-escaping function type error Jul 29, 2020
Copy link
Contributor

@xedin xedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@theblixguy
Copy link
Collaborator Author

@swift-ci please smoke test

@theblixguy theblixguy merged commit f2545dc into swiftlang:master Jul 29, 2020
@theblixguy theblixguy deleted the fix/improve-non-escaping-fix-it branch July 29, 2020 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants