[5.3] IRGen: Give ObjC metadata symbols internal linkage. #33193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
aschwaighofer
approved these changes
Jul 29, 2020
|
Build failed |
This preserves the symbol names in (unstripped) binaries, so we can use them for link ordering and memory usage analysis.
jckarter
force-pushed
the
internal-linkage-objc-symbols-5.3
branch
from
257d721 to
19ebcde
Compare
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
|
@swift-ci Please nominate |
airspeedswift
approved these changes
Jul 30, 2020
AnthonyLatsis
added
swift 5.3
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: This preserves the symbol names for ObjC metadata for Swift classes in (unstripped) binaries, so we can use them for link ordering and memory usage analysis.
Risk: Low, should be no impact on runtime behavior
Issue: rdar://problem/66292096
Testing: Swift CI
Reviewed by: @aschwaighofer