StringOptimization: bug fixes #33201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix some bugs in the optimization and in the test files. rdar://problem/66283894
|
@swift-ci smoke test and merge |
|
Hey @eeckstein this seems to have caused some regressions on the Windows builder: https://ci-external.swift.org/job/oss-swift-windows-x86_64-vs2019/2289/consoleText Could you please take a look? |
|
Thanks. I'll fix it asap. Edit: answering the question myself: this test only runs with a no-assert stdlib, which is not the case in PR testing. |
|
That should fix it: #33204 |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix some bugs in the optimization and in the test files.
rdar://problem/66283894