[5.3][CodeCompletion] Fix issue in dependency checking for the editing file #33210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'SM.getCodeCompletionBufferID()' returns the buffer ID of the previous code completion. 'CI.getCodeCompletionFile()->getBufferID()' always returns the original source buffer ID of the current file in the main module. The latter is needed for excluding buffer ID for dependency checking. rdar://problem/66301353 (cherry picked from commit 2f4dcf3)
|
@swift-ci Please test |
|
Build failed |
akyrtzi
approved these changes
Jul 30, 2020
|
@swift-ci test OS X platform |
|
@swift-ci Please nominate |
1 similar comment
|
@swift-ci Please nominate |
AnthonyLatsis
added
swift 5.3
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #33200 into
release/5.3SM.getCodeCompletionBufferID()as the "current editing file ID" but that is not correct because it points the buffer of the previous completion. We need to usegetBufferID()ofCI.getCodeCompletionFile()instead.