Skip to content

[5.3][CodeCompletion] Handle @autoclosure in context type analysis #33219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Jul 30, 2020

Cherry-pick of #33217 into release/5.3

  • Explanation: Unresolved member completion didn't use to work at argument position for @autoclosure parameters. Previously the context type is incorrectly resolved to a function type, but it should actually be the result type of the function type.
  • Scope: Context type analysis for code completion
  • Risk: Very Low. The change is trivial and safe
  • Testing: Added regression test cases
  • Issue: rdar://problem/65802490
  • Reviewer: Ben Langmuir (@benlangmuir)

If the context is '@autoclosure' parameter, the context type should be
the result type of it.

rdar://problem/65802490
(cherry picked from commit 3e558f0)
@rintaro rintaro added the r5.3 label Jul 30, 2020
@rintaro rintaro requested a review from a team as a code owner July 30, 2020 23:21
@rintaro
Copy link
Member Author

rintaro commented Jul 30, 2020

@rintaro Please test

@rintaro
Copy link
Member Author

rintaro commented Jul 31, 2020

@swift-ci Please nominate

@akyrtzi
Copy link
Contributor

akyrtzi commented Jul 31, 2020

@swift-ci Please test

@rintaro rintaro merged commit 91d3180 into swiftlang:release/5.3 Jul 31, 2020
@AnthonyLatsis AnthonyLatsis added swift 5.3 🍒 release cherry pick Flag: Release branch cherry picks labels Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 5.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants