Skip to content

[5.3] [IRGen] Add main() to __swift5_entry. #33269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

nate-chandler
Copy link
Contributor

To enable lookup of the entry point, emit a pointer to that entry point into a new section; on MachO, the __swift5_entry section of the __TEXT segment.

PR against master: #33246

rdar://problem/66402358

@nate-chandler nate-chandler requested a review from a team as a code owner August 3, 2020 22:02
@nate-chandler nate-chandler changed the title [IRGen] Add main() to __swift5_entry. [5.3] [IRGen] Add main() to __swift5_entry. Aug 3, 2020
@nate-chandler
Copy link
Contributor Author

@swift-ci please test

To enable lookup of the entry point, emit a pointer to that entry point
into a new section; on MachO, the __swift5_entry section of the __TEXT
segment.

rdar://problem/66402358
@nate-chandler nate-chandler force-pushed the emit-main-into-entry-segment-53 branch from 68d2c14 to 43a2929 Compare August 3, 2020 22:42
@nate-chandler
Copy link
Contributor Author

@swift-ci please test

1 similar comment
@nate-chandler
Copy link
Contributor Author

@swift-ci please test

@nate-chandler
Copy link
Contributor Author

@swift-ci please test windows

1 similar comment
@nate-chandler
Copy link
Contributor Author

@swift-ci please test windows

@swift-ci
Copy link
Contributor

swift-ci commented Aug 3, 2020

Build failed
Swift Test OS X Platform
Git Sha - 68d2c14d66e4181b863816aa72d0d7b201d66a9b

@swift-ci
Copy link
Contributor

swift-ci commented Aug 4, 2020

Build failed
Swift Test OS X Platform
Git Sha - 43a2929

@nate-chandler
Copy link
Contributor Author

@swift-ci please clean test macos

@swift-ci
Copy link
Contributor

swift-ci commented Aug 4, 2020

Build failed
Swift Test OS X Platform
Git Sha - 43a2929

@nate-chandler
Copy link
Contributor Author

@swift-ci please test

@nate-chandler nate-chandler force-pushed the emit-main-into-entry-segment-53 branch from 4c72fad to ec8873e Compare August 4, 2020 19:43
@nate-chandler
Copy link
Contributor Author

@swift-ci please test

1 similar comment
@nate-chandler
Copy link
Contributor Author

@swift-ci please test

@nate-chandler
Copy link
Contributor Author

@swift-ci please test windows

@tkremenek tkremenek merged commit 94929b6 into swiftlang:release/5.3 Aug 4, 2020
@nate-chandler nate-chandler deleted the emit-main-into-entry-segment-53 branch August 4, 2020 22:54
@AnthonyLatsis AnthonyLatsis added swift 5.3 🍒 release cherry pick Flag: Release branch cherry picks labels Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 5.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants