Skip to content

[AST] NFC: Fix ForeignErrorConvention constructor #33280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2020

Conversation

davezarzycki
Copy link
Contributor

Due to a quirk of how C++ "explicit" works, the ForeignErrorConvention constructor used Type instead of CanType. While we're in here, clean up some of the code.

@davezarzycki
Copy link
Contributor Author

@swift-ci please smoke test

@davezarzycki
Copy link
Contributor Author

@swift-ci please smoke test

@davezarzycki
Copy link
Contributor Author

@swift-ci please smoke test windows

@davezarzycki
Copy link
Contributor Author

@swift-ci please test windows

@davezarzycki
Copy link
Contributor Author

@swift-ci please clean test windows

@davezarzycki
Copy link
Contributor Author

@swift-ci please smoke test

@davezarzycki davezarzycki merged commit e4f5cc2 into swiftlang:master Aug 5, 2020
@davezarzycki davezarzycki deleted the pr33280 branch August 5, 2020 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant