Add a 'standalone_minimal' preset to build a minimal, static, OS independent, self-contained binaries of stdlib. #33286

kubamracek · 2020-08-04T17:29:07Z

This PR is the first step to be able to produce a new variant of the Swift Runtime and Standard Library — a minimal, static, self-contained build that is not tied to a particular operation system.

The building pieces are:

A new "freestanding" platform, which doesn't imply any particular OS.
A "min-size-release" build-script mode, which optimizes for size.
Some CMake options that allow specifying how to actually build the stdlib (which SDK, archs, and target triple to use).
A new preset that builds a "freestanding-x86_64" stdlib in this mode.

(Note that this is strictly for the runtime/stdlib, not for the compiler.)

gottesmm

Some thoughts/questions/etc.

utils/build-presets.ini

utils/swift_build_support/swift_build_support/targets.py

utils/build-presets.ini

test/CMakeLists.txt

cmake/modules/DarwinSDKs.cmake

cmake/modules/AddSwift.cmake

stdlib/cmake/modules/AddSwiftStdlib.cmake

cmake/modules/AddSwift.cmake

cmake/modules/SwiftUtils.cmake

kubamracek · 2020-08-05T20:46:59Z

@swift-ci please test

swift-ci · 2020-08-05T22:03:29Z

Build failed
Swift Test OS X Platform
Git Sha - d3cdc7de5f1b0d35b7d4253840f763825dc888a1

swift-ci · 2020-08-05T22:09:42Z

Build failed
Swift Test Linux Platform
Git Sha - d3cdc7de5f1b0d35b7d4253840f763825dc888a1

kubamracek · 2020-08-06T00:08:08Z

@swift-ci please test

swift-ci · 2020-08-06T00:08:45Z

Build failed
Swift Test OS X Platform
Git Sha - d3cdc7de5f1b0d35b7d4253840f763825dc888a1

swift-ci · 2020-08-06T00:11:00Z

Build failed
Swift Test Linux Platform
Git Sha - d3cdc7de5f1b0d35b7d4253840f763825dc888a1

utils/build-script-impl

utils/build-presets.ini

cmake/modules/AddSwift.cmake

cmake/modules/SwiftUtils.cmake

kubamracek · 2020-08-10T20:06:56Z

@swift-ci please test

swift-ci · 2020-08-10T20:07:17Z

Build failed
Swift Test Linux Platform
Git Sha - 3168f9d856550cbce3d5d55a3da1a210849f4a3a

swift-ci · 2020-08-10T20:10:15Z

Build failed
Swift Test OS X Platform
Git Sha - 3168f9d856550cbce3d5d55a3da1a210849f4a3a

kubamracek · 2020-08-10T23:59:40Z

@swift-ci please test

swift-ci · 2020-08-11T00:02:25Z

Build failed
Swift Test Linux Platform
Git Sha - ecff7ce73dbab6a3e63eeec2fba98cc42659f000

swift-ci · 2020-08-11T00:02:26Z

Build failed
Swift Test OS X Platform
Git Sha - ecff7ce73dbab6a3e63eeec2fba98cc42659f000

…ntained binaries of stdlib.

…'R' = Release, 'D' = Debug)

…ild_type

…uild-script-impl

… options

…Make options

…variant and a concrete preset for macho_x86_64

kubamracek · 2020-08-11T21:17:23Z

@swift-ci please test

swift-ci · 2020-08-11T21:17:48Z

Build failed
Swift Test Linux Platform
Git Sha - 8009391c5065be9c2b06cc30fecb17890cf1dfdb

swift-ci · 2020-08-11T21:20:04Z

Build failed
Swift Test OS X Platform
Git Sha - 8009391c5065be9c2b06cc30fecb17890cf1dfdb

kubamracek · 2020-08-12T01:02:20Z

@swift-ci please test

swift-ci · 2020-08-12T03:15:48Z

Build failed
Swift Test OS X Platform
Git Sha - e52a7b3

kubamracek · 2020-08-12T03:42:53Z

@swift-ci please test macOS platform

kubamracek requested review from compnerd, gottesmm, devincoughlin and airspeedswift August 4, 2020 17:29

gottesmm reviewed Aug 5, 2020

View reviewed changes

compnerd reviewed Aug 5, 2020

View reviewed changes

cmake/modules/AddSwift.cmake Show resolved Hide resolved

cmake/modules/SwiftUtils.cmake Outdated Show resolved Hide resolved

kubamracek changed the title ~~Add a 'standalone_minimal' preset to build a minimal, static, self-contained binaries of stdlib.~~ Add a 'standalone_minimal' preset to build a minimal, static, OS-independent, self-contained binaries of stdlib. Aug 5, 2020

gottesmm reviewed Aug 6, 2020

View reviewed changes

utils/build-script-impl Outdated Show resolved Hide resolved

gottesmm reviewed Aug 6, 2020

View reviewed changes

utils/build-presets.ini Show resolved Hide resolved

compnerd reviewed Aug 7, 2020

View reviewed changes

cmake/modules/AddSwift.cmake Outdated Show resolved Hide resolved

cmake/modules/SwiftUtils.cmake Outdated Show resolved Hide resolved

cmake/modules/SwiftUtils.cmake Outdated Show resolved Hide resolved

kubamracek changed the title ~~Add a 'standalone_minimal' preset to build a minimal, static, OS-independent, self-contained binaries of stdlib.~~ Add a 'standalone_minimal' preset to build a minimal, static, OS independent, self-contained binaries of stdlib. Aug 10, 2020

kubamracek added 7 commits August 11, 2020 13:51

Add a 'standalone_minimal' preset to build a minimal, static, self-co…

ee72334

…ntained binaries of stdlib.

Use 'S' as the build type letter ('S' = Size-optimized, analogous to …

63d4cff

…'R' = Release, 'D' = Debug)

Add comment explaining what 'Generic' is

26f65f0

Use clang_optimize_flag_for_build_type and swift_optimize_flag_for_bu…

8a478f3

…ild_type

Tweak FIXME comment in the preset

473eaba

Fix AddSwift to use clang_optimize_flag_for_build_type

d558632

Use 'os-independent' instead of 'generic'

79e535e

kubamracek added 10 commits August 11, 2020 13:51

Fix lint warning and missing test coverage in build_swift

2bcd993

Move SWIFT_SDKS out of extra-cmake-options into an explicit flag on b…

832b3f2

…uild-script-impl

Use swift-primary-variant-* build-script flags instead of extra CMake…

619d0e4

… options

Use swift-os-independent-* options in build-script instead of extra C…

d6bdc74

…Make options

Have 'S' and 'SA' presets for stdlib, then a mixin for the 'minimal' …

49283f1

…variant and a concrete preset for macho_x86_64

Move swift_optimize_flag_for_build_type to stdlib/cmake, add comment

b6d7a75

Avoid using clang_optimize_flag_for_build_type

ffcc471

Rename OS_INDEPENDENT to FREESTANDING

4e8b953

Fix python lint whitespace warning

da1c516

Stop using swift-sdks

e52a7b3

kubamracek force-pushed the add-generic-stdlib-variant branch from 8009391 to e52a7b3 Compare August 11, 2020 20:58

kubamracek merged commit ef89b0d into swiftlang:master Aug 12, 2020

kubamracek deleted the add-generic-stdlib-variant branch August 12, 2020 14:28

kubamracek mentioned this pull request Aug 18, 2020

Turn off library evolution for stdlib by default, keep it on only for Darwin #33535

Closed

Add a 'standalone_minimal' preset to build a minimal, static, OS independent, self-contained binaries of stdlib. #33286

Add a 'standalone_minimal' preset to build a minimal, static, OS independent, self-contained binaries of stdlib. #33286

Uh oh!

Conversation

kubamracek commented Aug 4, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gottesmm left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kubamracek commented Aug 5, 2020

Uh oh!

swift-ci commented Aug 5, 2020

Uh oh!

swift-ci commented Aug 5, 2020

Uh oh!

kubamracek commented Aug 6, 2020

Uh oh!

swift-ci commented Aug 6, 2020

Uh oh!

swift-ci commented Aug 6, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kubamracek commented Aug 10, 2020

Uh oh!

swift-ci commented Aug 10, 2020

Uh oh!

swift-ci commented Aug 10, 2020

Uh oh!

kubamracek commented Aug 10, 2020

Uh oh!

swift-ci commented Aug 11, 2020

Uh oh!

swift-ci commented Aug 11, 2020

Uh oh!

kubamracek commented Aug 11, 2020

Uh oh!

swift-ci commented Aug 11, 2020

Uh oh!

swift-ci commented Aug 11, 2020

Uh oh!

kubamracek commented Aug 12, 2020

Uh oh!

swift-ci commented Aug 12, 2020

Uh oh!

kubamracek commented Aug 12, 2020

Uh oh!

Uh oh!

kubamracek commented Aug 4, 2020 •

edited

Loading