Skip to content

[ownership] Begin updating existential specializer. #33295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

gottesmm
Copy link
Contributor

@gottesmm gottesmm commented Aug 4, 2020

I can not update all of the tests until I fix SILCombine and we move the
ownership lowering to right before the existential specializer (the sil tests
depend on the former and the swift tests depend on both). But this at least
begins updating the tests and ensures that the updates do not break the pass
when we run it on non-ossa code.

I can not update all of the tests until I fix SILCombine and we move the
ownership lowering to right before the existential specializer (the sil tests
depend on the former and the swift tests depend on both). But this at least
begins updating the tests and ensures that the updates do not break the pass
when we run it on non-ossa code.
@gottesmm gottesmm requested a review from meg-gupta August 4, 2020 21:37
@gottesmm
Copy link
Contributor Author

gottesmm commented Aug 4, 2020

@swift-ci test

@gottesmm
Copy link
Contributor Author

gottesmm commented Aug 4, 2020

@swift-ci benchmark

@gottesmm
Copy link
Contributor Author

gottesmm commented Aug 4, 2020

@swift-ci smoke test compiler performance

@swift-ci
Copy link
Contributor

swift-ci commented Aug 4, 2020

Performance: -O

Regression OLD NEW DELTA RATIO
SuffixArray 4 5 +25.0% 0.80x (?)
ObjectiveCBridgeStubToNSStringRef 70 76 +8.6% 0.92x (?)

Code size: -O

Performance: -Osize

Regression OLD NEW DELTA RATIO
FlattenListLoop 965 1532 +58.8% 0.63x (?)
FlattenListFlatMap 2765 4225 +52.8% 0.65x (?)
 
Improvement OLD NEW DELTA RATIO
DropWhileSequence 15 14 -6.7% 1.07x (?)

Code size: -Osize

Performance: -Onone

Code size: -swiftlibs

How to read the data The tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.

If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.

Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview
  Model Name: Mac mini
  Model Identifier: Macmini8,1
  Processor Name: 6-Core Intel Core i7
  Processor Speed: 3.2 GHz
  Number of Processors: 1
  Total Number of Cores: 6
  L2 Cache (per Core): 256 KB
  L3 Cache: 12 MB
  Memory: 64 GB

@swift-ci
Copy link
Contributor

swift-ci commented Aug 4, 2020

Build failed
Swift Test Linux Platform
Git Sha - 6017ef5

@gottesmm
Copy link
Contributor Author

gottesmm commented Aug 4, 2020

Linux was a time out.

@gottesmm
Copy link
Contributor Author

gottesmm commented Aug 4, 2020

@swift-ci test linux platform

@swift-ci
Copy link
Contributor

swift-ci commented Aug 5, 2020

Summary for master smoketest

No regressions above thresholds

Debug

debug brief

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (3)
name old new delta delta_pct
Frontend.NumInstructionsExecuted 1,627,053,931,715 1,625,394,136,761 -1,659,794,954 -0.1%
LLVM.NumLLVMBytesOutput 24,267,516 24,267,824 308 0.0%
time.swift-driver.wall 109.7s 109.9s 235.1ms 0.21%

debug detailed

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (16)
name old new delta delta_pct
AST.NumLoadedModules 3,334 3,334 0 0.0%
AST.NumTotalClangImportedEntities 31,374 31,374 0 0.0%
IRModule.NumIRBasicBlocks 87,267 87,267 0 0.0%
IRModule.NumIRFunctions 43,207 43,207 0 0.0%
IRModule.NumIRGlobals 48,853 48,853 0 0.0%
IRModule.NumIRInsts 1,133,647 1,133,647 0 0.0%
IRModule.NumIRValueSymbols 86,088 86,088 0 0.0%
LLVM.NumLLVMBytesOutput 24,267,516 24,267,824 308 0.0%
SILModule.NumSILGenFunctions 24,503 24,503 0 0.0%
SILModule.NumSILOptFunctions 29,205 29,205 0 0.0%
Sema.NumConformancesDeserialized 59,344 59,344 0 0.0%
Sema.NumConstraintScopes 140,791 140,791 0 0.0%
Sema.NumDeclsDeserialized 606,292 606,292 0 0.0%
Sema.NumGenericSignatureBuilders 10,691 10,691 0 0.0%
Sema.NumLazyIterableDeclContexts 101,882 101,882 0 0.0%
Sema.NumTypesDeserialized 224,107 224,107 0 0.0%

Release

release brief

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (3)
name old new delta delta_pct
Frontend.NumInstructionsExecuted 1,038,833,947,526 1,039,517,675,858 683,728,332 0.07%
LLVM.NumLLVMBytesOutput 29,839,564 29,839,404 -160 -0.0%
time.swift-driver.wall 170.4s 170.6s 104.6ms 0.06%

release detailed

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (16)
name old new delta delta_pct
AST.NumLoadedModules 266 266 0 0.0%
AST.NumTotalClangImportedEntities 10,500 10,500 0 0.0%
IRModule.NumIRBasicBlocks 77,960 77,960 0 0.0%
IRModule.NumIRFunctions 41,888 41,888 0 0.0%
IRModule.NumIRGlobals 53,269 53,269 0 0.0%
IRModule.NumIRInsts 777,946 777,946 0 0.0%
IRModule.NumIRValueSymbols 92,877 92,877 0 0.0%
LLVM.NumLLVMBytesOutput 29,839,564 29,839,404 -160 -0.0%
SILModule.NumSILGenFunctions 17,880 17,880 0 0.0%
SILModule.NumSILOptFunctions 14,561 14,561 0 0.0%
Sema.NumConformancesDeserialized 44,287 44,287 0 0.0%
Sema.NumConstraintScopes 164,028 164,028 0 0.0%
Sema.NumDeclsDeserialized 117,241 117,241 0 0.0%
Sema.NumGenericSignatureBuilders 3,271 3,271 0 0.0%
Sema.NumLazyIterableDeclContexts 15,122 15,122 0 0.0%
Sema.NumTypesDeserialized 63,135 63,135 0 0.0%

@gottesmm gottesmm merged commit 28b2f1e into swiftlang:master Aug 5, 2020
@gottesmm gottesmm deleted the pr-b4c03d477d7e5debea7371445387263cc9269360 branch August 5, 2020 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants