Skip to content

[5.3][Diagnostics] Detect and diagnose type mismatches related to function… #33299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2020

Conversation

xedin
Copy link
Contributor

@xedin xedin commented Aug 4, 2020

… builder result

Cherry-pick of #33298


  • Explanation:

Generic requirement failures are already covered but general type
mismatches have to be handled separately.

  • Scope: Limited to function builder bodies with produce incorrect type.

  • Resolves: rdar://problem/65413640

  • Risk: Very Low

  • Testing: Added regression tests

  • Reviewer: @hborla

Resolves: rdar://problem/65413640
(cherry picked from commit 9800790)

@xedin xedin requested a review from a team as a code owner August 4, 2020 21:57
@xedin xedin added the r5.3 label Aug 4, 2020
@xedin xedin changed the title [Diagnostics] Detect and diagnose type mismatches related to function… [5.3][Diagnostics] Detect and diagnose type mismatches related to function… Aug 4, 2020
@xedin
Copy link
Contributor Author

xedin commented Aug 4, 2020

@swift-ci please test

… builder result

Generic requirement failures are already covered but general type
mismatches have to be handled separately.

Resolves: rdar://problem/65413640
(cherry picked from commit 9800790)
@xedin xedin force-pushed the rdar-65413640-5.3 branch from 4ae8a8e to 6ccd013 Compare August 4, 2020 22:47
@xedin
Copy link
Contributor Author

xedin commented Aug 4, 2020

@swift-ci please test

@swiftlang swiftlang deleted a comment from swift-ci Aug 4, 2020
@swiftlang swiftlang deleted a comment from swift-ci Aug 4, 2020
@xedin xedin merged commit 80f8731 into swiftlang:release/5.3 Aug 5, 2020
@AnthonyLatsis AnthonyLatsis added swift 5.3 🍒 release cherry pick Flag: Release branch cherry picks labels Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 5.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants