[NFC] Break TypeResolver Down #33303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All of its component parts are now derived from the TypeResolution object. Just strip it of this unnecessary state and add projections instead.
Rename it while we're here.
|
@swift-ci smoke test |
Now that TypeResolvers and TypeResolution objects are cheap and easy to create, just use them instead of emplacing resolutions into the current resolver.
CodaFi
force-pushed
the
ownership-is-ninety-percent-of-the-law
branch
from
3d50a4d to
ccdc91b
Compare
|
@swift-ci smoke test |
|
@swift-ci smoke test windows |
|
⛵ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Strip
TypeResolverof some unnecessary state by deriving these values from theTypeResolutionobject it owns.There is no behavior change here.