Skip to content

[Localization] Ignore diagnostic IDs that are available in YAML and not in .def #33316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 5, 2020

Conversation

HassanElDesouky
Copy link
Contributor

This PR modifies ScalarEnumerationTraits to handle diagnostic IDs that are available in YAML and not in .def.

cc @xedin

@HassanElDesouky HassanElDesouky requested a review from xedin August 5, 2020 20:01
@xedin
Copy link
Contributor

xedin commented Aug 5, 2020

@swift-ci please smoke test

@xedin
Copy link
Contributor

xedin commented Aug 5, 2020

@swift-ci please smoke test macOS platform

@xedin xedin merged commit b647245 into swiftlang:master Aug 5, 2020
@HassanElDesouky HassanElDesouky deleted the localization-ignoreIDs branch August 6, 2020 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants