Skip to content

[test] Ensure clang importer sdk uses its own CoreFoundation overlay #33326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 7, 2020

Conversation

edymtt
Copy link
Contributor

@edymtt edymtt commented Aug 6, 2020

We noticed that Some tests using the clang importer sdk ended up using the CoreFoundation overlay built as part of
Swift instead of the mock one provided.

We noticed that Some tests using the clang importer sdk ended up using the CoreFoundation overlay built as part of
Swift instead of the mock one provided.
@edymtt
Copy link
Contributor Author

edymtt commented Aug 6, 2020

@swift-ci please smoke test

@edymtt
Copy link
Contributor Author

edymtt commented Aug 6, 2020

@swift-ci please test

@edymtt
Copy link
Contributor Author

edymtt commented Aug 6, 2020

@swift-ci please clean test Windows platform

Copy link
Contributor

@gottesmm gottesmm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@CodaFi
Copy link
Contributor

CodaFi commented Aug 7, 2020

👍

@CodaFi CodaFi merged commit b981d83 into swiftlang:master Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants