[Concurrency] Fix syntax tree creation #33333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had used the wrong kind of token for the contextual 'async' keyword (consistently), as well as flipping the order of async/throws when creating syntax nodes in the parser. Add a `-verify-syntax-tree` test with valid syntax to ensure that we don't make this mistake again. Problem found by Nate Chandler, thanks!
|
@swift-ci please smoke test |
|
SwiftSyntax update for this: swiftlang/swift-syntax#233 |
|
@swift-ci smoke test |
1 similar comment
|
@swift-ci smoke test |
|
@swift-ci smoke test |
|
@swift-ci smoke test |
1 similar comment
|
@swift-ci smoke test |
|
@swift-ci smoke test Linux |
|
@swift-ci test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bugs in the description and creation of the syntax tree for the experimental concurrency syntax:
asyncwasn't modeled correctly in the syntax treeasyncandthrowswere handled in the wrong order for function types__awaitexpressions were creating the wrong syntax nodes... all because I forgot to add a
-verify-syntax-treetest. Fix that mistake.