[Localization] Make the serialization tool print the removed diagnostics #33337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xedin
reviewed
Aug 6, 2020
HassanElDesouky
commented
Aug 6, 2020
xedin
requested changes
Aug 6, 2020
xedin
reviewed
Aug 7, 2020
xedin
reviewed
Aug 7, 2020
tools/swift-serialize-diagnostics/swift-serialize-diagnostics.cpp
Outdated
Show resolved
Hide resolved
xedin
reviewed
Aug 7, 2020
xedin
requested changes
Aug 7, 2020
HassanElDesouky
commented
Aug 8, 2020
HassanElDesouky
commented
Aug 8, 2020
HassanElDesouky
commented
Aug 9, 2020
xedin
reviewed
Aug 9, 2020
HassanElDesouky
commented
Aug 9, 2020
xedin
reviewed
Aug 9, 2020
xedin
requested changes
Aug 9, 2020
HassanElDesouky
force-pushed
the
localization-report-deleted-IDs
branch
from
6941ee9 to
a3b8014
Compare
|
I squashed all of the commits, I think it's ready now! :) |
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
|
Windows failure is related to #33381 |
|
@swift-ci please smoke test Windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I created a vector in
swift::diagthat will keep track of the diagnostic IDs that got removed from.defand still available in YAML. Then in theswift-serialize-diagnosticsI'm printing out all of the removed diagnostic IDs.cc @xedin