Skip to content

test: repair stdlib/Dispatch on ASi #33343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 8, 2020
Merged

Conversation

compnerd
Copy link
Member

@compnerd compnerd commented Aug 6, 2020

The conversion of the naonseconds to Mach ticks in multiples of Mach
timebase units alters the time. This would fail on ASi where mach ticks
are not synonymous with nanoseconds.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

@compnerd compnerd requested a review from kubamracek August 6, 2020 21:41
@compnerd
Copy link
Member Author

compnerd commented Aug 7, 2020

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented Aug 7, 2020

Build failed
Swift Test OS X Platform
Git Sha - c94c8378d900f6c27f3a4fd5c095e0e02ab24be5

The conversion of the naonseconds to Mach ticks in multiples of Mach
timebase units alters the time.  This would fail on ASi where mach ticks
are not synonymous with nanoseconds.
@compnerd
Copy link
Member Author

compnerd commented Aug 7, 2020

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented Aug 7, 2020

Build failed
Swift Test Linux Platform
Git Sha - c94c8378d900f6c27f3a4fd5c095e0e02ab24be5

@swift-ci
Copy link
Contributor

swift-ci commented Aug 7, 2020

Build failed
Swift Test OS X Platform
Git Sha - c94c8378d900f6c27f3a4fd5c095e0e02ab24be5

@compnerd compnerd merged commit 5782dd4 into swiftlang:master Aug 8, 2020
@compnerd compnerd deleted the dispatch-ASi branch August 8, 2020 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants