[ssa-updater] Modernize style before adding support for guaranteed parameters #33347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rameters. Specifically: 1. I made methods, variables camelCase. 2. I expanded out variable names (e.x.: bb -> block, predBB -> predBlocks, U -> wrappedUse). 3. I changed typedef -> using. 4. I changed a few c style for loops into for each loops using llvm::enumerate. NOTE: I left the parts needed for syncing to LLVM in the old style since LLVM needs these to exist for CRTP to work correctly for the SILSSAUpdater.
|
Oh I also fixed any/all instances of PHI -> Phi. |
|
@swift-ci test |
atrick
approved these changes
Aug 6, 2020
There was a problem hiding this comment.
I'm fine with this but bb is generally an accepted abbreviation for basicBlock. I don't want to give that up everywhere. There are very few of these all-lower acronyms, like ii. They're pervasive and they directly mirror the typename so there's no possibility for confusion.
|
Thanks for fixing |
|
@swift-ci test windows platform |
|
@atrick I am going to do a follow up that undoes those changes b/c I want to validate the bigger change was NFC here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically:
NOTE: I left the parts needed for syncing to LLVM in the old style since LLVM
needs these to exist for CRTP to work correctly for the SILSSAUpdater.
Just getting this off my local branch so it can percolate a little.