[Sema] Allow inference of binding to differing lvalue-ness type var… #33363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jumhyn
commented
Aug 7, 2020
Jumhyn
force-pushed
the
SR-13357
branch
2 times, most recently
from
3b31f70 to
19ee28d
Compare
xedin
reviewed
Aug 7, 2020
Jumhyn
force-pushed
the
SR-13357
branch
3 times, most recently
from
4505d41 to
5cacf2c
Compare
xedin
approved these changes
Aug 8, 2020
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
|
Looks like this also fixed a case of pattern matching to unwrapped base in case statement |
when we have an optional type. This uncovered an error with unresolved member lookup where we allowed an unresolved value member constraint to fail if lookup failed in an optional type wrapping a type variable. This resolves SR-13357.
|
@xedin Updated to remove the expected diagnostic, and fixed the assertion failure! |
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
|
@swift-ci please test source compatibility debug |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when we have an optional type. This uncovered an error with unresolved member lookup where we allowed an unresolved value member constraint to fail if lookup failed in an optional type wrapping a type variable.
This resolves SR-13357.