Fix edgecase in AllocBoxToStack handling of local apply #33376
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
Build failed |
meg-gupta
force-pushed
the
fixallocboxtostack
branch
from
3d39e2c to
4d4af13
Compare
|
@swift-ci smoke test |
|
@swift-ci test |
|
Build failed |
|
Build failed |
|
@swift-ci test windows platform |
|
@swift-ci Please Test Source Compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AllocBoxToStack analyzes alloc_boxes passed into a chain of applies and converts the alloc_box to alloc_box along with specializing the eligible functions when it is safe to do so from - #31907
This PR fixes an edge case in the construction of AppliesToSpecialize when multiple alloc_boxes are passed to n common function.
Also added a flag to disable the analysis of apply in AllocBoxToStack.
Fixes rdar://66542551