Skip to content

[ConstraintSystem] A couple of adjustments to make interaction between solution and code completion simpler #33406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 11, 2020
Merged

[ConstraintSystem] A couple of adjustments to make interaction between solution and code completion simpler #33406

merged 3 commits into from
Aug 11, 2020

Conversation

xedin
Copy link
Contributor

@xedin xedin commented Aug 11, 2020

  • Add a variant of isStaticallyDerivedMetatype to Solution
  • Fix incorrect exist condition in solveForCodeCompletion
  • Add Solution::getResolvedType to avoid repetitive simplifyType(getType(ASTNode)) pattern

xedin added 3 commits August 11, 2020 12:10
@xedin
[ConstraintSystem] Add isStaticallyDerivedMetatype to Solution
54d2581 
This is useful for a new style code completion which doesn't apply
solutions back to neither constraint system nor AST.
@xedin
[CSSolver] solveForCodeCompletion should fail if constraint generat…
a81b7d1 
…ion fails
@xedin
[ConstraintSystem] Add Solution::getResolvedType to get a concrete …
73262ae 
…type for a given `ASTNode`
@xedin xedin requested a review from nathawes August 11, 2020 19:21
@xedin
Copy link
Contributor Author

xedin commented Aug 11, 2020

@swift-ci please smoke test

nathawes
nathawes approved these changes Aug 11, 2020
View reviewed changes
Copy link
Contributor

@nathawes nathawes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@xedin xedin merged commit 17e5ec4 into swiftlang:master Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathawes nathawes nathawes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xedin @nathawes